search

gr2m / initials

extract initials from and add initials to names
https://gr2m.github.io/initials
MIT License
44 stars 14 forks source link

Avoid same initials for similar names #14 #16

Closed javimolla closed 9 years ago

javimolla commented 9 years ago

Had to change one test to pass because now it accepts initials for one name even if they are shared with another name, as long as the other name has it's own different initials For that, I had to reverse your merge and reversed the iteration for initialsForNamesMap on lines 172-176

Sorry for my english, code and pull request. I'm a totally newbie in this

gr2m commented 9 years ago

Wow @javimolla, your Pull Request is really, really good! I'm impressed with how few changes you figured out a way to fix #14! I'll merge this as is, I'll only squash your two commit messages into one and change the working a bit so that it fits our commit message conventions. Thanks so much :bouquet:

gr2m commented 9 years ago

merged via 9ca0654

varjmes commented 9 years ago

Great PR @javimolla :D Congratulations on your first contribution to Open Source!

javimolla commented 9 years ago

Thank you very much!