gr2m
commented
9 years ago The way you export initials in https://github.com/gr2m/initials/blob/auto-deploy/index.js will make this fail
var initials = require('initials')
initials('John Doe')Instead we'd need to do
var initials = require('initials').initials
initials('John Doe')Which is not what we want. I would simply do
var exports = module.exports = require('./lib/initials')Later we can then split up the addTo, find and parse functions into multiple files, but let's do it in another PR :)
this does not yet fully finish #13, initials.js is not commonJS and there is no build task, but we can do this in two steps. But then do not move the index.html to demo/index.html, because it will break gh-pages. The index.html will be accessible at http://gr2m.github.io/initials/demo instead of http://gr2m.github.io/initials