Can't handle emoji in names

gr2m / initials

extract initials from and add initials to names

https://gr2m.github.io/initials

MIT License

44 stars 14 forks source link

Can't handle emoji in names #30

Closed Froelund closed 5 years ago

Froelund commented 7 years ago

Emojis ends up as an illegal character:

t.equal(initials('John 🐐face'), 'J🐐', 'John 🐐face (j🐐) ☛ j🐐');

✖ John 🐐face (j🐐) ☛ j🐐
    --------------------------
      operator: equal
      expected: 'J🐐'
      actual:   'J�'
      stack: |-

gr2m commented 7 years ago

that’s a new one :) How would you fix it?

Froelund commented 7 years ago

Yes! The times they are a-changin' 👍 I don't know what the exact issue is, but I suspect something with number of bytes taken from the lastname doesn't match the length of the first character(emoji).

gr2m commented 7 years ago

So I see two ways addressing this

Mention in the README that initials doesn’t handle emojis well
Implement some good handling of emojis that I don’t see right now :)

gr2m commented 6 years ago

@Froelund did you come up with a workaround?