gr2m / merge-schedule-action

GitHub Action to merge pull requests on a scheduled day
ISC License
143 stars 36 forks source link

Option to allow merging from forks #86

Open IstoraMandiri opened 1 year ago

IstoraMandiri commented 1 year ago

In #6, all PRs from forked repos are ignored.

It is understandable to ignore forked repos by default, but in the following case, shouldn't this be allowed?

If the target branch is protected and requires maintainer approval(s) for merging, it can be assumed that the PR, once approved, is safe to merge and should be allowed to be scheduled whether or not it's from a forked repo.

gr2m commented 1 year ago

I'm still afraid this might cause unwanted merges.

I'd be okay to turn this into an option that makes explicit how dangerous it is, something like a dangerously_enable_merges_from_forks option, and even then I'd check if branch protections are enabled.

If you or someone else wants to work on it, make sure to update docs and add tests