search

gr2m / moment-parseformat

A moment.js plugin to extract the format of a date/time string
http://gr2m.github.io/moment-parseformat
Apache License 2.0
45 stars 30 forks source link

installed latest moment (bower_components) ... #28

Closed mwymann closed 9 years ago

mwymann commented 9 years ago

... and successfully ran unit tests (grunt qunit).

gr2m commented 9 years ago

I'm not a bower_components pro, but I guess we can add ./bower_components to .gitignore? You have to update it in package.json and run npm install to have the tests run with latest moment

mwymann commented 9 years ago

thats right! didn't want to make breaking changes to your project settings. but now i added bower_components to gitignore.

it is not necessary to install both npm package and bower component of moment, so I also removed the npm package. do you agree? local tests succeeded.

gr2m commented 9 years ago

it is not necessary to install both npm package and bower component of moment, so I also removed the npm package. do you agree? local tests succeeded.

You can't remove the package.json, otherwise people will not be able to install it via npm any more :) That's also why the tests failed on travis I guess. If you remove the node_modules folder locally, things will fall apart :)

gr2m commented 9 years ago

Ah I'm sorry, I know why I left the bower_components folder in git. It's used on the website at http://gr2m.github.io/moment.parseFormat/. That's also why gh-pages is the main branch. Sorry for all the trouble, let me look quickly into this.

gr2m commented 9 years ago

done via 46ef27e

mwymann commented 9 years ago

thanks for your effort. it would be nice, if you update your bower component.

gr2m commented 9 years ago

for bower I need to do a new tag on github, right?

mwymann commented 9 years ago

that's right. You need a tag with new version number (semantic version, eg: v1.3.1) corresponding to the version in your bower.json.

for further info: http://bower.io/docs/creating-packages/#register

gr2m commented 9 years ago

yeah, new versions / tags get created automatically trough https://www.npmjs.com/package/semantic-release, so next time a bug gets fixed or a feature gets added, the new version gets released. But if you need it now, I'll trigger a new release manually, no biggie

mwymann commented 9 years ago

great. would be nice to have a release right now to update all my projects...

gr2m commented 9 years ago

Release is on it's way: https://travis-ci.org/gr2m/moment.parseFormat/builds/66364594 1.0.1 is released

Glad to hear you are using moment.parseFormat in several projects :) Is there anything that you can show? I'd love to see how others use it.

mwymann commented 9 years ago

unfortunately nothing in production yet. ;)

gr2m commented 9 years ago

Okay :) holla when you have something to show