search

gr2m / moment-parseformat

A moment.js plugin to extract the format of a date/time string
http://gr2m.github.io/moment-parseformat
Apache License 2.0
45 stars 30 forks source link

Add epoch times #29

Closed khornberg closed 9 years ago

khornberg commented 9 years ago

So, I wanted to make an input element take any date possible and normalize it to something. In my searching I found moment.parseFormat which had already completed most of the work. Thanks! I also wanted the ability to take epoch times.

Example of what I mean https://jsfiddle.net/b0xmrus8/

gr2m commented 9 years ago

Could you reword the two commits to follow the conventions that semantic-release to do its auto-release dance?

I'd suggest

  1. test: add unix timestamp support
  2. feat: add unix timestamp support

I think it's always nice to commit the test, too. Makes it easier to double check if the tests were red, before fixing / adding missing feature.

If that's too much hassle, no worries, I can do it for you :+1:

khornberg commented 9 years ago

sure

gr2m commented 9 years ago

I'm so sorry I totally missed your update, we'll get it merged soon, promise

khornberg commented 9 years ago

No worries. Thanks.

Kyle

On Fri, Aug 28, 2015 at 11:48 AM, Gregor Martynus notifications@github.com wrote:

I'm so sorry I totally missed your update, we'll get it merged soon, promise

— Reply to this email directly or view it on GitHub https://github.com/gr2m/moment.parseFormat/pull/29#issuecomment-135829921 .

gr2m commented 9 years ago

released as moment-parseformat@1.1.0 :ship: :package: :+1: