search

gr2m / moment-parseformat

A moment.js plugin to extract the format of a date/time string
http://gr2m.github.io/moment-parseformat
Apache License 2.0
45 stars 30 forks source link

Add support for Number as input for parseFormat #64

Closed idanb11 closed 7 years ago

idanb11 commented 7 years ago

Added needed test.

gr2m commented 7 years ago

your test is failing, it needs some implementation, are you still on it?

idanb11 commented 7 years ago

I don't know, It doesn't fail on my side:

$ node test/moment-parseformat-test.js
TAP version 13
# standard cases
ok 1 Thursday 9:20pm → dddd h:mma
ok 2 Thursday, February 6th, 2014 9:20pm → dddd, MMMM Do, YYYY h:mma
ok 3 23:20 → H:mm
ok 4 02/03/14 → MM/DD/YY
ok 5 2014-01-10 20:00:15 → YYYY-MM-DD H:mm:ss
ok 6 Thursday at 9:20pm → dddd [at] h:mma
ok 7 1397418578 → X
# GitHub issues
ok 8 #3 Thursday, February 6th, 2014 9:20pm -> dddd, MMMM Do, YYYY h:mma
ok 9 #3 sanity check: "Thursday, February 6th, 2014 9:20pm" parses 6th correctly
ok 10 #4 1.1.2010 → D.M.YYYY
ok 11 #11 9-17-1980 → M-D-YYYY
ok 12 #5 2014-02-02T10:11:58+00:00 → YYYY-MM-DDTHH:mm:ssZ
ok 13 #5 August 26, 2014 02:30pm → MMMM D, YYYY hh:mma
ok 14 #5 August 06, 2014 → MMMM DD, YYYY
ok 15 #12 3-1-81 → D-M-YY
ok 16 #15 01-01-2015 → DD-MM-YYYY
ok 17 #15 01-01-2015 (preferredOrder: MDY) → MM-DD-YYYY
ok 18 #20 10/8/2014 5:08:35 PM → M/D/YYYY h:mm:ss A
ok 19 #20 10/8/2014 5:08:35 am → M/D/YYYY h:mm:ssa
ok 20 #23 2014-23-04T01:20:28.888+02:00 → YYYY-MM-DDTHH:mm:ss.SSSZ
ok 21 #23 2014-09-04T01:20:28.888+02:00 → YYYY-MM-DDTHH:mm:ss.SSSZ
ok 22 #23 2014-09-04T01:20:28.888-02:00 → YYYY-MM-DDTHH:mm:ss.SSSZ
ok 23 #23 2014-02-02T10:11:58.888Z → YYYY-MM-DDTHH:mm:ss.SSSZ
ok 24 1434575583 → X
ok 25 1318781876406 → x
ok 26 October 27 2015 11:28:32.0 → MMMM D YYYY HH:mm:ss.S
ok 27 October 27 2015 11:28:32.0 → MMMM D YYYY HH:mm:ss.SS
ok 28 October 27 2015 11:28:32.0 → MMMM D YYYY HH:mm:ss.SSS
ok 29 Feb 1 2016 1:03:22.111 → MMM D YYYY H:mm:ss.SSS
ok 30 Feb 1 2016 1:03:22.111 → MMM D YYYY H:mm:ss.SS
ok 31 Feb 1 2016 1:03:22.111 → MMM D YYYY H:mm:ss.S
ok 32 #56 2014-23-04T01:20:28.888+0200 → YYYY-MM-DDTHH:mm:ss.SSSZ
ok 33 #56 2014-09-04T01:20:28.888+0200 → YYYY-MM-DDTHH:mm:ss.SSSZ
ok 34 #56 2014-09-04T01:20:28.888-0200 → YYYY-MM-DDTHH:mm:ss.SSSZ
ok 35 #56 2014-09-04T01:20:28+0200 → YYYY-MM-DDTHH:mm:ssZ
# GitHub issues - special cases
ok 36 last number is > 12 - 3/15 → M/Y
ok 37 last number is > 12 - 03/15 → MM/Y
ok 38 last number is > 12 - 11/15 → MM/Y
ok 39 first number is > 12 - 15/3 → DD/M
ok 40 both numbers are < 13 - 03/12 → DD/MM
ok 41 both numbers are < 13 - 3/3 → D/M
ok 42 first number is > 12 && <= 31 - 13/2 → DD/M
ok 43 both numbers are < 13 - 03/12 → DD/MM
ok 44 both numbers are < 13 - 03/03 → DD/MM
ok 45 first number is > 12 && <= 31 - 13/02 → DD/MM
ok 46 both numbers are < 13 - 3/12 → D/MM
ok 47 February 6th, 2014 9.20 → MMMM Do, YYYY h.mm
ok 48 2.2.2014 09.20 → D.M.YYYY H.mm
ok 49 2.2.2014 11.20 → D.M.YYYY H.mm
ok 50 2.2.2014 9.02 → D.M.YYYY h.mm
# Github issue #40
ok 51 31/12/2013 → DD/MM/YYYY
ok 52 12/31/2013 → MM/DD/YYYY
ok 53 31-12-2013 → DD-MM-YYYY
ok 54 12-31-2013 → MM-DD-YYYY

1..54
# tests 54
# pass  54

# ok

I added test No. 7

idanb11 commented 7 years ago

This is what fails:

> moment-parseformat@ pretest /home/travis/build/gr2m/moment-parseformat
> standard
standard: Use JavaScript Standard Style (http://standardjs.com)
  /home/travis/build/gr2m/moment-parseformat/lib/parseformat.js:20:31: Unnecessary escape character: \/.
  /home/travis/build/gr2m/moment-parseformat/lib/parseformat.js:20:33: Unnecessary escape character: \..
  /home/travis/build/gr2m/moment-parseformat/lib/parseformat.js:20:35: Unnecessary escape character: \-.
  /home/travis/build/gr2m/moment-parseformat/lib/parseformat.js:20:49: Unnecessary escape character: \/.
  /home/travis/build/gr2m/moment-parseformat/lib/parseformat.js:20:51: Unnecessary escape character: \..
  /home/travis/build/gr2m/moment-parseformat/lib/parseformat.js:20:53: Unnecessary escape character: \-.
  /home/travis/build/gr2m/moment-parseformat/lib/parseformat.js:22:27: Unnecessary escape character: \-.
  /home/travis/build/gr2m/moment-parseformat/lib/parseformat.js:57:30: Unnecessary escape character: \/.
  /home/travis/build/gr2m/moment-parseformat/lib/parseformat.js:57:41: Unnecessary escape character: \/.
npm ERR! Test failed.  See above for more details.
gr2m commented 7 years ago

Okay cheers, I got it