search

gr2m / octokit-plugin-create-pull-request

Octokit plugin to create a pull request with multiple file changes
MIT License
104 stars 28 forks source link

feat: add support for labels #131

Closed stefanbuck closed 1 year ago

stefanbuck commented 1 year ago

Fixes #102

Gotchas

gr2m commented 1 year ago
  • If user doesn't have permissions to add labels, it still creates the PR but without labels. Do we want to log an info to the console?

Yes I think that'd be good

  • When running against an existing pull request it does not remove any previous set labels. This could cause confusion, especially if a previous run was using another label e.g. had a typo.

We could log something as well, to explain that labels are added, not replaced?

stefanbuck commented 1 year ago

Should I be using console.log like in other places or move all logging to octokit.log?

gr2m commented 1 year ago

Should I be using console.log like in other places or move all logging to octokit.log?

I'd always use octokit.log in the context of Octokit plugins.

stefanbuck commented 1 year ago

Took me some time to return to this pull request, but you can find the latest changes in e60b64947234d3c0da3a91e06874c739e95408ac

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 5.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

stefanbuck commented 1 year ago

great PR, thanks!

Just following the breadcrumbs here

stefanbuck commented 1 year ago

That said, updating the fixtures isn't straight forward, but I can't think of a better way.

oscard0m commented 1 year ago

Thanks for this contribution @stefanbuck ❤️