?. operated in dist-web breaks SSR

gr2m / octokit-plugin-create-pull-request

Octokit plugin to create a pull request with multiple file changes

MIT License

104 stars 28 forks source link

?. operated in dist-web breaks SSR #68

Closed pelikhan closed 3 years ago

pelikhan commented 3 years ago

I'm seeing some webpack failures with the latest release due to the ?. operator.

https://github.com/gr2m/octokit-plugin-create-pull-request/blob/f2abf7fe1acdc07685306ee53069778e12080629/src/compose-create-pull-request.ts#L66

ERROR #98123  WEBPACK

Generating development SSR bundle failed

Unexpected token (137:29)

File:node_modules/octokit-plugin-create-pull-request/dist-web/index.js:137:29

gr2m commented 3 years ago

Make sure you use the latest typescript version?

pelikhan commented 3 years ago

I think since it's a javascript file, typescript does not rewrite index.js.

gr2m commented 3 years ago

Oh I see, the built JS has that syntax!

https://unpkg.com/browse/octokit-plugin-create-pull-request@3.9.2/dist-web/index.js#L137

Thank you, I'll look into it

github-actions[bot] commented 3 years ago

:tada: This issue has been resolved in version 3.9.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: