search

gr2m / octokit-plugin-create-pull-request

Octokit plugin to create a pull request with multiple file changes
MIT License
104 stars 28 forks source link

Update existing pull request #99

Closed gr2m closed 2 years ago

gr2m commented 2 years ago

I ran into this so often and always ended up implementing some workaround. But today is the day, I'll add an option like update that can be set to true and false. It will default to false to not break current behavior, but I think in future I'll default it to true instead because from my own experience that is the desired behavior.

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 3.12.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

st3phhays commented 2 years ago

I am using this feature, and am able to update the pull request title successfully, but if I pass in new files to be added to the PR, those files are not shown at all. I am not able to update existing files in the pull request either. Is this intentional, or is there another way to do this?

I am just getting started with octokit.js. Apologies if I'm missing something obvious!

gr2m commented 2 years ago

Definitely not intended, it should add new files when updating a pull request. Could you please create a new issue, ideally also sharing a minimal code example that reproduces the problem? I'll be happy to help

st3phhays commented 2 years ago

Thanks a lot! I created a new issue https://github.com/gr2m/octokit-plugin-create-pull-request/issues/107