testing new all-contributors app

cloudflare-worker-example[bot] commented 3 years ago

Hello there from Cloudflare Workers

gr2m commented 3 years ago

@all-contributors please add @gr2m-test for infrastructure, tests and code

all-contributors-preview[bot] commented 3 years ago

@gr2m

I've put up a pull request to add @gr2m-test! :tada:

gr2m commented 3 years ago

@all-contributors please add @gr2m-test for infrastructure, tests and code

all-contributors-preview[bot] commented 3 years ago

@gr2m

I've updated the pull request to add @gr2m-test! :tada:

gr2m commented 3 years ago

@all-contributors please add @gr2m-test for code

all-contributors-preview[bot] commented 3 years ago

@gr2m

I've updated the pull request to add @gr2m-test! :tada:

gr2m commented 3 years ago

@all-contributors please add @gr2m-test for tests

all-contributors-preview[bot] commented 3 years ago

@gr2m

I've updated the pull request to add @gr2m-test! :tada:

gr2m commented 3 years ago

@all-contributors please add @gr2m-test for infrastructure

all-contributors-preview[bot] commented 3 years ago

@gr2m

I've updated the pull request to add @gr2m-test! :tada:

gr2m commented 3 years ago

@all-contributors please add @gr2m-test for infrastructure

allcontributors[bot] commented 3 years ago

@gr2m

I've put up a pull request to add @gr2m-test! :tada:

gr2m commented 3 years ago

@all-contributors please add @gr2m-test for tests

allcontributors[bot] commented 3 years ago

@gr2m

I've put up a pull request to add @gr2m-test! :tada:

gr2m commented 3 years ago

@all-contributors please add @gr2m for tests

allcontributors[bot] commented 3 years ago

@gr2m

I've put up a pull request to add @gr2m! :tada:

gr2m commented 3 years ago

@all-contributors please add @Berkmann18 for mentoring

all-contributors-preview[bot] commented 3 years ago

@gr2m

I've put up a pull request to add @Berkmann18! :tada:

Berkmann18 commented 3 years ago

@all-contributors please add @Berkmann18 for code

all-contributors-preview[bot] commented 3 years ago

@Berkmann18

We had trouble processing your request. Please try again later.

gr2m commented 3 years ago

the error was

TypeError: Cannot read property 'files' of undefined
    at Config.get (/var/task/lib/modules/config.js:73:32)
    at convertMessage (/var/task/lib/modules/convert-message.js:5:49)
    at Repository.updateFile (/var/task/lib/modules/repository.js:128:16)
    at Repository.createOrUpdateFile (/var/task/lib/modules/repository.js:153:18)
    at /var/task/lib/modules/repository.js:166:27
    at Array.map (<anonymous>)
    at Repository.createOrUpdateFiles (/var/task/lib/modules/repository.js:164:69)
    at Repository.createPullRequestFromFiles (/var/task/lib/modules/repository.js:236:16)
    at addContributor (/var/task/lib/add-contributor.js:51:24)
    at async processIssueComment (/var/task/lib/process-issue-comment.js:61:33)

gr2m commented 3 years ago

It should have been reported to sentry, the sentry event ID is 22c294492d3b4aaca6c44d1a8748cdcd. But it's not showing up in the sentry.io app yet

Berkmann18 commented 3 years ago

It may be taking time in showing up. As for the error, I'll see if I can find a better solution whenever I'm free.

gr2m commented 3 years ago

I think it's the same error that you see in the tests here? https://github.com/all-contributors/app/pull/343/checks?check_run_id=1723922388#step:5:13

Berkmann18 commented 3 years ago

That's true and it indeed seems that it only fails in the PR. Edit: It should hopefully work now.

Berkmann18 commented 3 years ago

@all-contributors please add @Berkmann18 for code

all-contributors-preview[bot] commented 3 years ago

@Berkmann18

I've updated the pull request to add @Berkmann18! :tada:

Berkmann18 commented 3 years ago

Note (to self): check if the PR title is consistent with the commits when (the convention isn't Angular) if so the PR would be good to go.

Berkmann18 commented 3 years ago

@all-contributors please add @gr2m for infra

all-contributors-preview[bot] commented 3 years ago

@Berkmann18

I've updated the pull request to add @gr2m! :tada:

Berkmann18 commented 3 years ago

It seems like we need to have tests that read a mocked/dummy .all-contributorsrc and test when some of the values there differ. I'm not sure why there's an inconsistency in the PR above.

gr2m commented 3 years ago

looks like https://github.com/gr2m/sandbox/pull/167 was created by the @allcontributors app, not by @all-contributors-preview. Sorry, my fault. I installed the @allcontributors app all of my @gr2m repositories and forgot that I tested the preview here in this repo.

How about we create a new organization @all-contributors-sandbox for dedicated testing?

all-contributors-preview[bot] commented 3 years ago

@gr2m

I could not determine your intention.

Basic usage: @all-contributors please add @someone for code, doc and infra

For other usages see the documentation

all-contributors-preview[bot] commented 3 years ago

@all-contributors-preview[bot]

I've put up a pull request to add @someone! :tada:

gr2m commented 3 years ago

oh oh :D

gr2m / sandbox

testing new all-contributors app #163