gr2m / universal-github-app-jwt

Calculate GitHub App bearer tokens for Node & modern browsers
MIT License
24 stars 11 forks source link

fix: bump jsonwebtoken to 9.0.2 #78

Closed nitrocode closed 10 months ago

nitrocode commented 10 months ago

what

npm i jsonwebtoken
git add -u

why

references

wolfy1339 commented 10 months ago

Although this fix is fine, npm should be able to pick this version up as it's a patch version, and the dependency in this package is set to accept any version within the major version number.

gr2m commented 10 months ago

something's wrong with the release automation: https://github.com/gr2m/universal-github-app-jwt/actions/runs/7405964716/job/20149666339

I'm looking into it

github-actions[bot] commented 10 months ago

:tada: This PR is included in version 1.1.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

nitrocode commented 10 months ago

@gr2m thanks for fixing it

I noticed that the new version is shown as the latest. That's probably not intentional since there is a 2.x which is probably more recent.

nitrocode commented 10 months ago

@wolfy1339 I tried doing an npm install for a package that uses this package but this package would still use 9.0.0 instead of 9.0.2 unless I explicitly updated it. Perhaps it's because of the package-lock.json file or perhaps I'm doing something wrong?

Thanks for merging anyway. This at least gets snyk to stop complaining 😄