Setup of ODE Solver Script

gr812b / CVT-Simulator

Other

2 stars 0 forks source link

Setup of ODE Solver Script #58

Closed gr812b closed 2 weeks ago

gr812b commented 3 weeks ago

Description Initial POC with python script, ODE solver, proper structure, etc Changes List the main changes made in this PR:

[X] Initial setup of simplistic ODE solver
[X] Proper python file structure
[X] OOP approach on utilizing scipys ODE solver for clear typing
[X] Made project a package so that any module can be run independently

Additional Notes Will look at introducing the load via a hill / slope, and maybe air resistance

gr812b commented 3 weeks ago

Only nitpick would be more consistency, some files have tons of comments and others have none. Not sure what direction we want to go in but probably better to pick one

Did you find the comments in say engine_simulation helpful? I'm on the fence as the code looks a lot messier and harder to read but maybe the context (and units) are helpful?