gr8pefish / IronBackpacks

A Minecraft mod that adds portable storage in the form of tiered backpacks with modular upgrades.
GNU General Public License v3.0
60 stars 33 forks source link

[ Fix ] - [ Config Bugs ] #235

Closed ghost closed 6 years ago

ghost commented 6 years ago

Issue Description:

Problems with the in-game config, and problems with manipulating the physical config file manually and its in-game effects.

What happens:

In game config does not properly change the physical file associated with the behavior of the backpacks. When reloading the game the changes made are reverted. When you manipulate the physical config file, it does work though. However, only the removal of upgrades works, if you change the inventory space of the backpacks, and then start up the game, the back packs capacity will not change and will remain the same as how it originally was without any changes, despite the fact that the in-game config shows the custom values.

More specifically I changed the backpack capacity to as follows: Basic: 9 IronStorage: 18 IronUpgrade: 9 GoldStorage: 27 GoldUpgrade: 18 DiamondStorage: 36 DiamondUpgrade: 27

None of the backpacks ever changed their capacity.

What you expected to happen:

What was expected was for the config system to function accordingly/appropriately.

Steps to reproduce (important):

  1. Attempt to edit the in-game config, exit config, reopen config, see that the settings saved.
  2. Restart game after step 1, and reopen game, see that the config reset/did not save.
  3. Edit the config file manually (such as disabling upgrades and changing backpack capacity), discover that the upgrade disabling/enabling worked, but changing the capacity of the backpacks did not, despite the fact that in the config it now shows the custom capacity values set. ...

Affected Versions (Do not use "latest"):


I do hope this can be addressed/is verified as an issue to be fixed in the next Beta/Release 👍 :)

TehNut commented 6 years ago

Ah, we forgot to add the actual reloading subscription.

ie:

https://github.com/WayofTime/BloodMagic/blob/389043dc64718f3443ea50182999aca8b1410d7a/src/main/java/WayofTime/bloodmagic/ConfigHandler.java#L28-L36