search

gr8pefish / IronBackpacks

A Minecraft mod that adds portable storage in the form of tiered backpacks with modular upgrades.
GNU General Public License v3.0
60 stars 33 forks source link

Backpacks can be put in each other. #244

Open DreenDex opened 6 years ago

DreenDex commented 6 years ago

Issue Description:

Any backpacks from Iron Backpacks can be put inside each other using Shift-Click.

What happens:

One backpack goes inside another. Other ways of doing this are banned.

What you expected to happen:

One backpack not going inside another backpack.

Steps to reproduce (important):

  1. Get 2 backpacks in inventory.
  2. Open 1 backpack.
  3. Quick-move (Shift+LMB) other backpack.

Affected Versions (Do not use "latest"):

Screenshot

image

RhysWhy commented 6 years ago

I can replicate this. I think we just need to check for the clicktype of QUICK_MOVE in ContainerBackpack.canTake and test the slot stack to see if it is an IBackpack

Trnrr commented 5 years ago

Will the next version ever be uploaded to curse? I just downloaded the latest beta and it still lets you shift them inside backpacks.