search

graalvm / graal-js-jdk11-maven-demo

An example project how to run Graal/JavaScript on JDK 11 with Graal as optimizing JIT compiler for best performance.
Universal Permissive License v1.0
177 stars 63 forks source link

Would it be possible to create a version for JDK17? #40

Open Yaytay opened 2 years ago

Yaytay commented 2 years ago

I thought I'd got my build working with JDK17 following your example (using Zulu on Windows), but when I run in GitHub Actions (Zulu on Ubuntu) Surefire bombs out with the message: Cannot use JVMCI compiler: No JVMCI compiler found. It is unclear what the implications of removing JVMCI are for polyglot programming on OpenJDK.

Yaytay commented 2 years ago

Oh, actually I think I might have just resolved my issue. In the pom you have: --upgrade-module-path=${compiler.dir}/compiler.jar:${compiler.dir}/compiler-management.jar To work on Windows that needs a semicolon: --upgrade-module-path=${compiler.dir}/compiler.jar;${compiler.dir}/compiler-management.jar

The docs (https://docs.oracle.com/en/java/javase/17/docs/specs/man/java.html) are quite specific that is should be a semicolon, but that definitely doesn't work on Linux. Fortunately the docs also state that it's a list of directories, so this seems to work: --upgrade-module-path=${compiler.dir}

stanio commented 1 year ago

I guess this has been adjusted in b690c6c370ef24a41e173f93b42ce0bcc3f7272c, now.