search

graalvm / graal-js-jdk11-maven-demo

An example project how to run Graal/JavaScript on JDK 11 with Graal as optimizing JIT compiler for best performance.
Universal Permissive License v1.0
177 stars 63 forks source link

Use OS-independent path separator #41

Closed anthonyvdotbe closed 2 years ago

anthonyvdotbe commented 2 years ago

This makes the project buildable out-of-the-box on Windows as well.

graalvmbot commented 2 years ago

Hello Anthony Vanelverdinghe, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address dev -(at)- anthonyv -(dot)- be. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

anthonyvdotbe commented 2 years ago

I've already signed the OCA

wirthi commented 2 years ago

Hi @anthonyvdotbe

thanks for your contribution.

I can confirm you have signed the OCA, will add you to our (GraalVM's) list of signatories in order to pass this check. (EDIT: see you have already been added by Doug). Should be resolved by the next sync between our CIs.

Thanks, Christian

fniephaus commented 2 years ago

In fact, your contribution was already merged via https://github.com/graalvm/graal-js-jdk11-maven-demo/commit/b690c6c370ef24a41e173f93b42ce0bcc3f7272c. For some reason, this PR wasn't marked as merged as part of this, so I'm closing it now.

Again, thanks for your contribution!