graalvm / graal-js-jdk11-maven-demo

An example project how to run Graal/JavaScript on JDK 11 with Graal as optimizing JIT compiler for best performance.
Universal Permissive License v1.0
177 stars 63 forks source link

Make the project compilable on vanilla JDK8 #8

Closed JaroslavTulach closed 5 years ago

JaroslavTulach commented 5 years ago

I believe it is desirable to make sure the project can be compiled on any JDK8. That also removes the need for special configuration of JDK in the IDEs when the project is opened.

First of all let's enable testing on JDK8.

JaroslavTulach commented 5 years ago

The project compiles on vanilla JDK8 since 8e1e8a2. Tests that require Graal.js are skipped. The execution on vanilla JDK8 stops and instructs user to download GraalVM or use JDK11.

JaroslavTulach commented 5 years ago

With this change I can open the project in NetBeans without the IDE showing any error:

graal-js-jdk11-maven-demo$ /netbeans-8.2/bin/netbeans --userdir /tmp/tmpuserdir --jdkhome /usr/lib/jvm/java-8-oracle/ .

I believe other IDEs will provide similar experience and open the project without showing any errors.