graalvm / mandrel-packaging

6 stars 8 forks source link

Revert conditionalSteps and introduce combinations filter parameter #296

Closed zakkak closed 1 year ago

zakkak commented 1 year ago

It turns out conditionalSteps don't do exactly what I expected, i.e., they don't result in the job being skipped, but instead skip running the tests and mark the job as successful which is misleading (and requires us to accept empty junit reports and artifacts in the publishers).

As a result, I suggest we revert these changes and instead use the Matrix Combinations Plugin, which allows one to parameterize the combinationFilter when running a job manually.

This results in the user being prompted with something like the following when building "with Parameters" (which also has more applications than just skipping jobs when a build number is not present for the combination):

image

Karm commented 1 year ago

Makes sense to me.

I used to do this manually via Axes + parameters + combination filter: Parameter: PARAM_X: Options: ALL OPTION_1 OPTION_2

Axes: OPTIONS: OPTION_1 OPTION_2

Filter !(OPTIONS != PARAM_X && PARAM != ALL)

or something to that effect.

The Combinations Filter plugin seem to effectively automate this :+1: