graalvm / mandrel-packaging

6 stars 8 forks source link

Windows fails to build with 23 and master due to libchelper.lib location change #346

Closed Karm closed 1 year ago

Karm commented 1 year ago

i.e.

Used to be: C:\tmp\mandrel\substratevm\mxbuild\windows-amd64\com.oracle.svm.native.libchelper\amd64\libchelper.lib

It is now:

C:\tmp\mandrel\substratevm\mxbuild\windows-amd64-jdk17\com.oracle.svm.native.libchelper\amd64\libchelper.lib

jerboaa commented 1 year ago

Should be fixed with: https://github.com/graalvm/mandrel-packaging/pull/342 are you using latest master?

Karm commented 1 year ago

@jerboaa I most definitely am.

git clone --depth 1 --branch master https://github.com/graalvm/mx
git clone --depth 1 --branch master https://github.com/graalvm/mandrel-packaging
git clone --depth 1 --branch mandrel/23.0 https://github.com/graalvm/mandrel
call vcvars64
set JAVA_HOME=C:\tmp\JDK
set PATH=%JAVA_HOME%\bin;%PATH%
java -ea ./mandrel-packaging/build.java --mx-home C:/tmp/mx --mandrel-repo C:/tmp/mandrel --archive-suffix zip --verbose 2>&1 | tee log.log
Karm commented 1 year ago

When I reverted the fix from #342 is has started to work for me again, the build completes and then fails to compile native agent for an unrelated reason (old VS).

jerboaa commented 1 year ago

OK, thanks. So it appears #342 should only be there for 23.1+. I'll create a 23.0 mandrel-packaging branch with the fix reverted.

jerboaa commented 1 year ago

NVM. We should be using the 23.0 branch for building 23.0. That tree doesn't have the change.