search

graalvm / mandrel-packaging

6 stars 8 forks source link

Add support for local maven deployment #355

Closed jerboaa closed 1 year ago

jerboaa commented 1 year ago

Example usage which installs the current version into the local maven repo (~/.m2 on Linux):

$ java -ea ./build.java --maven-deploy-local --mandrel-version $MANDREL_VERSION --verbose --mx-home $MX_HOME --mandrel-repo $MANDREL_REPO --mandrel-home $MANDREL_HOME

Closes: #354

jerboaa commented 1 year ago

Thanks for the review! Don't merge this just yet (still some things coming).

Can't you achieve local deployment with --maven-repo-id local --maven-version 3.6.0 --maven-url file://$HOME/.m2/repository

It's a mvn deploy vs. mvn install call. I'd prefer an install so as to not even attempt to go remote. Also using the internal install logic frees us from trying to re-dediscover the local repo and all that.

jerboaa commented 1 year ago

@zakkak Please review again. https://github.com/graalvm/mandrel/issues/526#issuecomment-1645662414 contains a draft as to where this is going.

github-actions[bot] commented 1 year ago

This PR appears to be stale because it has been open 30 days with no activity. This PR will be closed in 7 days unless Stale label is removed or a new comment is made.

jerboaa commented 1 year ago

This PR depends on #360

jerboaa commented 1 year ago

CI passes with this in the 23.1 branch. See https://github.com/jerboaa/mandrel-packaging/actions/runs/6099726559

I'm merging this.