graalvm / mandrel-packaging

6 stars 8 forks source link

Replace graal-sdk with nativeimage, word, and collections #358

Closed zakkak closed 1 year ago

zakkak commented 1 year ago

Package was split in https://github.com/oracle/graal/pull/7171

Depends on https://github.com/oracle/graal/pull/7205

zakkak commented 1 year ago

This implicitly will no longer build graal-sdk, which is the only GraalVM dependency in Quarkus. We need to carefully look at what dependencies we need to replace this with on the Quarkus end. Also affects graal-sdk not being built with --java-only which affects the product build.

Good point, so before moving forward with this we need to see what the plans for the upstream graal-sdk maven artifact are. If it's indeed going to keep getting published as is we should not remove it from our builds.

Update: I created https://github.com/graalvm/mandrel-packaging/pull/359 as an alternative

jerboaa commented 1 year ago

I'm thinking to go with this one for now and keep a close eye out on https://github.com/oracle/graal/discussions/7224 and do all necessary preparations to move to the new API maven artefact.

jerboaa commented 1 year ago

On second thought, we might need to go with #359 after all so as to build graal-sdk which will be the dep Quarkus is currently using. It cannot be changed easily, since Quarkus wants to work with older GraalVM releases as well. So we might want to change to a slimmer build a few releases in the future only.

jerboaa commented 1 year ago

This PR has the same problem when testing GRAAL_SDK local deployment as #359. See https://github.com/graalvm/mandrel-packaging/pull/359#issuecomment-1686653281

zakkak commented 1 year ago

superseded by #360