search

graalvm / mandrel-packaging

6 stars 8 forks source link

Temporarily move to building 23.1 #361

Closed jerboaa closed 1 year ago

jerboaa commented 1 year ago

Graal master branch is currently not buildable (in the Mandrel config) and is, thus, not helpful for CI runs. In order to avoid breakages I propose to move to 23.1 temporarily.

This patch also does the following (in separate commits):

jerboaa commented 1 year ago

Switching to JDK 21 will be needed too...

jerboaa commented 1 year ago

https://github.com/graalvm/mandrel-packaging/pull/361/commits/a7f770dc54ce4174a583cd5bad49700853c03052 should be easily revertable once we have 24.0/master working again.

zakkak commented 1 year ago

Graal master branch is currently not buildable (in the Mandrel config) and is, thus, not helpful for CI runs. In order to avoid breakages I propose to move to 23.1 temporarily.

I am not sure how useful that is. mandrel-packaging's master branch is meant to build mandrel's oracle/master branch, if that's broken then the CI should fail as it does.

For building/testing 23.1 builds we should use https://github.com/graalvm/mandrel-packaging/tree/23.1 IMO if we need a change for 23.1 that we probably want in master as well we should open a PR against 23.1 and if all looks good open the same PR against master and merge it despite the CI failing on master.

Other than that, it looks good to me.

jerboaa commented 1 year ago

OK. Replaced by https://github.com/graalvm/mandrel-packaging/pull/363

jerboaa commented 1 year ago

For building/testing 23.1 builds we should use https://github.com/graalvm/mandrel-packaging/tree/23.1 IMO if we need a change for 23.1 that we probably want in master as well we should open a PR against 23.1

PR against 23.1 is here: https://github.com/graalvm/mandrel-packaging/pull/362