search

graalvm / mandrel-packaging

6 stars 8 forks source link

Change CI workflows to use 23.1 #362

Closed jerboaa closed 1 year ago

jerboaa commented 1 year ago

Fix CI for 23.1 branch.

This patch does the following (in separate commits):

zakkak commented 1 year ago

The 2 step build fails with:

AttributeError: 'Namespace' object has no attribute 'generate_javadoc'

Could it be that we are using the wrong mx version? i.e. mx master might not be compatible with 23.1

jerboaa commented 1 year ago

The 2 step build fails with:

AttributeError: 'Namespace' object has no attribute 'generate_javadoc'

Could it be that we are using the wrong mx version? i.e. mx master might not be compatible with 23.1

Possibly. It passed yesterday, though (with mx revision c86b9e88a23ec263d9f19b754b29d30dd18272da). See: https://github.com/graalvm/mandrel-packaging/actions/runs/6087706591

Let me try with it.

zakkak commented 1 year ago

I suggest pinning the mx version to 6.42.0 (or possibly get it from common.json, although I recall having some difficulty in doing so), see https://github.com/graalvm/mandrel/blob/mandrel/23.1/common.json#L7

jerboaa commented 1 year ago

I suggest pinning the mx version to 6.42.0 (or possibly get it from common.json, although I recall having some difficulty in doing so), see https://github.com/graalvm/mandrel/blob/mandrel/23.1/common.json#L7

Sure that works too. I'll let the run with 6.45.0 complete and then possibly tune it down to 6.42.0

jerboaa commented 1 year ago

@zakkak CI is happy. Do you want me to use 6.42.0 instead or is 6.45.0 good enough?

zakkak commented 1 year ago

I am OK with either.

jerboaa commented 1 year ago

OK, merging as is then. Thanks!