search

graalvm / mandrel-packaging

6 stars 8 forks source link

[23.1] Set MaxRAM and MaxRAMPercentage in launcher for native-image driver #365

Closed zakkak closed 1 year ago

zakkak commented 1 year ago

Closes https://github.com/graalvm/mandrel/issues/557

Candidate for master branch as well, but opening against 23.1 first due to https://github.com/graalvm/mandrel/issues/558

jerboaa commented 1 year ago

We should bring this upstream once we have some experience with this.

zakkak commented 1 year ago

provided CI is OK.

CI running the full Quarkus test suite: https://github.com/graalvm/mandrel/actions/runs/6196136877

zakkak commented 1 year ago

provided CI is OK.

CI look good.

jerboaa commented 11 months ago

@zakkak How do you feel about bringing this upstream? Fabio was interested in having it for the bash launcher too once we have some experience. Thoughts?

zakkak commented 11 months ago

My only (minor) concern is that this has not been tested in the wild yet. We can wait for Mandrel 23.1 to be released and used by Quarkus for some time first. Although this is not expected to affect GraalVM CE builds, so we could go ahead without waiting as well.

jerboaa commented 11 months ago

OK. Let's wait for the 23.1 release to happen, then move Quarkus to it and re-evaluate in a few months time.

jerboaa commented 7 months ago

We should bring this upstream once we have some experience with this.

@zakkak We have been running with this for a while now with no issues. Should we bring this upstream?

zakkak commented 7 months ago

Yes, I haven't seen any issues with it so far.

zakkak commented 7 months ago

Created https://github.com/oracle/graal/pull/8366

jerboaa commented 7 months ago

Thanks!