graalvm / mandrel-packaging

6 stars 8 forks source link

[PR tester] Windows build fails - failing to create a directory in ninja build #386

Closed jerboaa closed 7 months ago

jerboaa commented 8 months ago

Starting with #384 we see weird Windows build failures in the ninja build. The error looks like:

2024-01-08T17:34:40.6448804Z ninja -j 1 -v 
2024-01-08T17:34:40.6449054Z [6876: started subprocess 4660: ['ninja', '-j', '1', '-v']]
2024-01-08T17:34:40.6449800Z ninja: error: mkdir(D_/a/mandrel-packaging/mandrel-packaging/mandrel/substratevm/mxbuild/jdk23/svm-jvmfuncs-fallback-builder): No such file or directory
2024-01-08T17:34:40.6451788Z [1/3] cl -nologo -showIncludes -ID:\a\mandrel-packaging\mandrel-packaging\mandrel\substratevm\src\com.oracle.svm.native.jvm.windows\src -ID:\a\mandrel-packaging\mandrel-packaging\jdk\include -ID:\a\mandrel-packaging\mandrel-packaging\jdk\include\win32  -MD -Zi -O2 -DJNIEXPORT= -c D:\a\mandrel-packaging\mandrel-packaging\mandrel\substratevm\src\com.oracle.svm.native.jvm.windows\src\JvmFuncs.c -Fosrc\JvmFuncs.obj
2024-01-08T17:34:40.6451882Z ninja: build stopped: .
2024-01-08T17:34:40.6452335Z Building com.oracle.svm.native.jvm.windows_windows-amd64-default with Ninja: Failed due to error: 1

The mkdir call using a mangled non-windows path of D_/a/mandrel-packaging/mandrel-packaging/mandrel/substratevm/mxbuild/jdk23/svm-jvmfuncs-fallback-builder over D:\a\mandrel-packaging\mandrel-packaging\mandrel\substratevm\mxbuild\jdk23\svm-jvmfuncs-fallback-builder seems to cause this. I don't know what makes ninja build change this (or try to create that directory) while for other CI Windows builds we don't see it.

This needs investigation. /cc @Karm @zakkak

jerboaa commented 8 months ago

Example failure we see in CI is here: https://github.com/graalvm/mandrel-packaging/actions/runs/7494241350/job/20401713155?pr=388#step:9:432

jerboaa commented 8 months ago

Further info as the PR tester uses a different workflow that we use for mandrel nightly CI (where we don't see the issue). It does not seem related to:

jerboaa commented 8 months ago

We only see this issue for Graal master, 24.1 (JDK 23 based builds). See https://github.com/graalvm/mandrel-packaging/pull/390 which has a clean CI run here: https://github.com/graalvm/mandrel-packaging/actions/runs/7501144635?pr=390

github-actions[bot] commented 7 months ago

This issue appears to be stale because it has been open 30 days with no activity. This issue will be closed in 7 days unless Stale label is removed or a new comment is made.

jerboaa commented 7 months ago

We don't seem to see those issues any more. See for example: https://github.com/graalvm/mandrel-packaging/actions/runs/7901681233/job/21565689677?pr=405

Closing for now.