search

graalvm / mandrel-packaging

6 stars 8 forks source link

[23.0] Introduce `--disable-debuginfo-stripping` option #387

Closed zakkak closed 8 months ago

zakkak commented 8 months ago

Enables the use of --disable-debuginfo-stripping which was introduced in https://github.com/oracle/graal/pull/7624

zakkak commented 8 months ago

Follow up PRs will be created for 23.1, 24.0, and master once this gets approved.

jerboaa commented 8 months ago

Enables the use of --disable-debuginfo-stripping which was introduced in oracle/graal#7624

Right, that was introduced to master with that change, but it also got backported to 23.0 here: https://github.com/oracle/graal/commit/cdb0389887fbfff5fb368a04f1bb9986dc55883a

Therefore, adding that option to mandrel-packaging seems fine with that in place.

zakkak commented 8 months ago

Thanks for mentioning this, I was struggling to see what's wrong... :)

jerboaa commented 8 months ago

@zakkak Oh, I've just realized this doesn't yet work on Windows:

 VERSION=$(jq -r .mx_version ${MANDREL_REPO}/common.json): D:\a\_temp\9b0ef8ba-4f46-4891-af53-35e0c27ce28b.ps1:2
Line |
   2 |  VERSION=$(jq -r .mx_version ${MANDREL_REPO}/common.json)
     |  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | The term 'VERSION=$(jq -r .mx_version ${MANDREL_REPO}/common.json)' is not recognized as a name of a cmdlet,
     | function, script file, or executable program. Check the spelling of the name, or if a path was included, verify
     | that the path is correct and try again.