Closed jerboaa closed 5 months ago
I've tested this locally with --maven-deploy-local
.
Before this patch (no manifests in source jars):
$ for i in word collections nativeimage; do echo "----------------------- $i ------------------------"; echo $i.jar=$(jar -tf mandrel-build/lib/jvmci/$i.jar | grep MANIFEST); echo $i.src.zip=$(jar -tf mandrel-build/lib/jvmci/$i.src.zip | grep MANIFEST); done
----------------------- word ------------------------
word.jar=META-INF/MANIFEST.MF
word.src.zip=
----------------------- collections ------------------------
collections.jar=META-INF/MANIFEST.MF
collections.src.zip=
----------------------- nativeimage ------------------------
nativeimage.jar=META-INF/MANIFEST.MF
nativeimage.src.zip=
After this patch (manifests in both, the regular jars and the source jar):
$ for i in word collections nativeimage; do echo "----------------------- $i ------------------------"; echo $i.jar=$(jar -tf mandrel-build/lib/jvmci/$i.jar | grep MANIFEST); echo $i.src.zip=$(jar -tf mandrel-build/lib/jvmci/$i.src.zip | grep MANIFEST); done
----------------------- word ------------------------
word.jar=META-INF/MANIFEST.MF
word.src.zip=META-INF/MANIFEST.MF
----------------------- collections ------------------------
collections.jar=META-INF/MANIFEST.MF
collections.src.zip=META-INF/MANIFEST.MF
----------------------- nativeimage ------------------------
nativeimage.jar=META-INF/MANIFEST.MF
nativeimage.src.zip=META-INF/MANIFEST.MF
Merging as this is needed for a release coming up.
Thanks for taking care of this @jerboaa
Diff ignoring whitespace looks like this:
FYI you can get this diff on github by appending the URL with ?w=1
or by clicking the gear box in the "Files Changed" tab of the PR and ticking "Hide whitespace"
OK. Thanks for the tip!
For Quarkus productization source jars are expected to have META-INF/MANIFEST.MF files in them. Inject them when they're not already there like we do for the actual jar artefact.
Diff ignoring whitespace looks like this: