search

graalvm / mandrel-packaging

6 stars 8 forks source link

[24.0] Backport: Better handling of MANIFEST.MF attributes #438

Closed zakkak closed 1 month ago

zakkak commented 1 month ago

Backport of https://github.com/graalvm/mandrel-packaging/pull/435

Previously, the build script would add these two attributes irrespective whether or not they'd exist in the Graal artefacts:

Specification-Version Implementation-Version

With this patch, only updates to the Implementation-Version attribute are done based on the maven version in use. Specification-Version is only added if it's not yet there in a jar or source jar file.

(cherry picked from commit 48c154e09da76394c09f3ed9b1ae03ed699d0df5)

jerboaa commented 1 month ago

@zakkak Since we need it in 24.0, we probably also need it in 24.1. Otherwise, we'd have 24.0 and 24.2 fixed and 24.1 not.

zakkak commented 1 month ago

@jerboaa In 24.0 we need it due to https://github.com/oracle/graal/commit/d2bba8feea48fc6e224c43803f4bfe65099d7ecd and https://github.com/graalvm/mx/commit/5eb6d6f73d16a37f52c9d69815af479523513bdd

24.1 is still using mx 7.25.5 which doesn't include https://github.com/graalvm/mx/commit/bafad626087bccdc7cb1032cca68a5bcddff1ff2 so for the time being we don't need the backport (except for consistency).

jerboaa commented 1 month ago

24.1 is still using mx 7.25.5 which doesn't include graalvm/mx@bafad62 so for the time being we don't need the backport (except for consistency).

@zakkak We should also provide the backport in 24.1. There is a good chance the same will happen there. Lets fix it before it's an issue. The backport is low-risk enough.

zakkak commented 1 month ago

Done in https://github.com/graalvm/mandrel-packaging/pull/439