graalvm / mandrel-packaging

6 stars 8 forks source link

[24.1] Backport: Better handling of MANIFEST.MF attributes #439

Closed zakkak closed 1 month ago

zakkak commented 1 month ago

Backport of https://github.com/graalvm/mandrel-packaging/pull/435

Previously, the build script would add these two attributes irrespective whether or not they'd exist in the Graal artefacts:

Specification-Version Implementation-Version

With this patch, only updates to the Implementation-Version attribute are done based on the maven version in use. Specification-Version is only added if it's not yet there in a jar or source jar file.

(cherry picked from commit 48c154e09da76394c09f3ed9b1ae03ed699d0df5)

zakkak commented 1 month ago

CI failures should be fixed by https://github.com/oracle/graal/pull/9315 I will update mandrel/24.1 and rerun

zakkak commented 1 month ago

Now we get a different error:

/usr/bin/ld: hellostrict.o:(.data+0x60): undefined reference to `svm_container_physical_memory'
/usr/bin/ld: hellostrict.o:(.data+0x158): undefined reference to `svm_container_active_processor_count'
/usr/bin/ld: hellostrict.o:(.data+0x528): undefined reference to `svm_container_initialize'
collect2: error: ld returned 1 exit status

It looks like mandrel/24.1 with JDK 23+31 is broken (but not yet caught by the CI which runs on a weekly manner)

jerboaa commented 1 month ago

/usr/bin/ld: hellostrict.o:(.data+0x60): undefined reference to svm_container_physical_memory' /usr/bin/ld: hellostrict.o:(.data+0x158): undefined reference tosvm_container_active_processor_count' /usr/bin/ld: hellostrict.o:(.data+0x528): undefined reference to `svm_container_initialize' collect2: error: ld returned 1 exit status

This would be fixed by a backport of https://github.com/graalvm/mandrel-packaging/pull/430

jerboaa commented 1 month ago

It looks like mandrel/24.1 with JDK 23+31 is broken (but not yet caught by the CI which runs on a weekly manner)

Unfortunately, yes. Not sure if we should test 24.1 nightly?

zakkak commented 1 month ago

It looks like mandrel/24.1 with JDK 23+31 is broken (but not yet caught by the CI which runs on a weekly manner)

Unfortunately, yes. Not sure if we should test 24.1 nightly?

Things are not moving that fast there, IMHO running once a week (plus on the manual syncs I do with upstream) is OK.

jerboaa commented 1 month ago

It looks like mandrel/24.1 with JDK 23+31 is broken (but not yet caught by the CI which runs on a weekly manner)

Unfortunately, yes. Not sure if we should test 24.1 nightly?

Things are not moving that fast there, IMHO running once a week (plus on the manual syncs I do with upstream) is OK.

OK.

zakkak commented 1 month ago

This would be fixed by a backport of #430

Apparently the CI pipeline was still trying to build graal/master.

jerboaa commented 1 month ago

This would be fixed by a backport of #430

Apparently the CI pipeline was still trying to build graal/master.

Ah, makes sense.