graalvm / mandrel

Mandrel is a downstream distribution of the GraalVM community edition. Mandrel's main goal is to provide a native-image release specifically to support Quarkus.
Other
394 stars 15 forks source link

[23.1] Backport: Minor JNI and libchelper fixes #737

Closed zakkak closed 4 months ago

zakkak commented 4 months ago

Backport of https://github.com/oracle/graal/pull/7955

Resolves build issues like:

[7/10] CC src/getThreadId.o
FAILED: src/getThreadId.o 
gcc -MMD -MF src/getThreadId.o.d -I/home/zakkak/code/mandrel/substratevm/src/com.oracle.svm.native.libchelper/include  -fdebug-prefix-map=/home/zakkak/code/mandrel=mandrel -fdebug-prefix-map=/home/zakkak/code/mandrel/substratevm/mxbuild/jdk21=jdk21 -fdebug-prefix-map=/home/zakkak/jvms/jdk-21.0.4+2=jdk-21.0.4+2 -gno-record-gcc-switches -g -gdwarf-4 -fPIC -O2 -D_LITTLE_ENDIAN -ffunction-sections -fdata-sections -fvisibility=hidden -D_FORTIFY_SOURCE=0 -c /home/zakkak/code/mandrel/substratevm/src/com.oracle.svm.native.libchelper/src/getThreadId.c -o src/getThreadId.o
/home/zakkak/code/mandrel/substratevm/src/com.oracle.svm.native.libchelper/src/getThreadId.c: In function ‘getThreadId’:
/home/zakkak/code/mandrel/substratevm/src/com.oracle.svm.native.libchelper/src/getThreadId.c:39:17: error: implicit declaration of function ‘syscall’ [-Wimplicit-function-declaration]
   39 |   return (pid_t)syscall(SYS_gettid);
      |                 ^~~~~~~
ninja: build stopped: subcommand failed.
, -2)
jerboaa commented 4 months ago

Two failing checks are due to https://github.com/graalvm/mandrel/issues/732. I guess we should investigate a fix for this or see passing checks with 21.0.3 (JDK 21 GA).

zakkak commented 4 months ago

Two failing checks are due to #732. I guess we should investigate a fix for this

I plan to do this in another PR

or see passing checks with 21.0.3 (JDK 21 GA).

I scheduled https://github.com/graalvm/mandrel/actions/runs/9179917652

zakkak commented 4 months ago

I scheduled https://github.com/graalvm/mandrel/actions/runs/9179917652

CI looks good. Merging.