[24.1] Backport: Updated JFR substitutions from [GR-54877]

graalvm / mandrel

Mandrel is a downstream distribution of the GraalVM community edition. Mandrel's main goal is to provide a native-image release specifically to support Quarkus.

Other

397 stars 15 forks source link

[24.1] Backport: Updated JFR substitutions from [GR-54877] #764

Closed roberttoyonaga closed 4 months ago

roberttoyonaga commented 4 months ago

(cherry picked from commit fbc44e955f24be7de1c6364fc3256273c0763073)

A change to OpenJDK JFR was introduced in JDK 24 and later backported to JDK23+29. The Mandrel GHAs are using JDK23+29 so builds that include JFR will fail due to out of date substitutions.

roberttoyonaga commented 4 months ago

Failing GHAs:

Mandrel-Quarkus tests / Q main M 24.1 EA / Q IT Data6 Looks unrelated. Seems related to: io.quarkus.it.hibernate.search.orm.elasticsearch.coordination.outboxpolling.HibernateSearchOutboxPollingInGraalIT.testSearch.
Mandrel-Quarkus tests / Q main M 24.1 EA / Q IT Messaging1 Also seems unrelated. Related to an authentication failure io.quarkus.it.kafka.KafkaOauthIT.test
Mandrel-Quarkus tests / Q main M 24.1 EA / Q Mandrel IT Will be fixed once https://github.com/graalvm/mandrel/pull/762 is merged

roberttoyonaga commented 4 months ago

LGTM other than the references to JDK 24 source code. @roberttoyonaga could you please adapt them accordingly? Thank you

yes, thanks for spotting that. Done!

jerboaa commented 4 months ago

CI failures are known:

Q main M 23 latest / Q IT Messaging1: quarkus-integration-test-kafka-oauth-keycloak native integration failure due to: https://github.com/quarkusio/quarkus/issues/39634.
Q main M 23 latest / Q IT Data6: quarkus-integration-test-hibernate-search-orm-elasticsearch-outbox-polling fails due to a version parsing issue of 23-beta as reported in https://github.com/quarkusio/quarkus/issues/39664 (caused by this upstream awaitability issue: https://github.com/awaitility/awaitility/issues/277). We see the same on 22-beta builds.
Q Mandrel IT: Is caused by awt integration tests failing on JDK 23. See https://github.com/Karm/mandrel-integration-tests/issues/262

zakkak commented 4 months ago

This backport was replaced by upstream https://github.com/oracle/graal/commit/27149a9b18a12eff1ae5983af16362a0bd191481, but we kept https://github.com/graalvm/mandrel/pull/764/commits/e308905953dd047c54aedd6e605090f3f626d000 on top of it.