search

graalvm / setup-graalvm

GitHub Action for setting up GraalVM distributions.
https://www.graalvm.org
Universal Permissive License v1.0
195 stars 28 forks source link

Add `cache-hit` to `outputs` #23

Closed armanbilge closed 1 year ago

armanbilge commented 1 year ago

Looks like you are already outputting this info, just need to make it official :) https://github.com/graalvm/setup-graalvm/blob/79e8ca0cface7983a272b9291502a91914dd19f8/src/features/cache.ts#L135-L142

outputs is based on: https://github.com/actions/setup-java/blob/de1bb2b0c5634f0fc4438d7aa9944e68f9bf86cc/action.yml#L70-L78

oracle-contributor-agreement[bot] commented 1 year ago

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

armanbilge commented 1 year ago

Can I ... not sign the OCA for such a trivial change? Started signing up but it's not a short form, requiring lots of info.

I'd dedicate this change to public domain, but honestly it's copied verbatim out of MIT-licensed setup-java. https://github.com/actions/setup-java

fniephaus commented 1 year ago

Thanks for bringing this up, @armanbilge. The action now outputs cache-hit.

armanbilge commented 1 year ago

Thanks!