search

graalvm / setup-graalvm

GitHub Action for setting up GraalVM distributions.
https://www.graalvm.org
Universal Permissive License v1.0
192 stars 27 forks source link

Set default-value for gds-token #41

Closed johannes-link closed 1 year ago

johannes-link commented 1 year ago

Hi @fniephaus,

Thanks for your work on GraalVM and on this GitHub action.

I've found the following bug: Currently there is no default value set for 'gds-token'. When I try to use GraalVM CE in this GitHub-action I get the error message 'Bad credentials'. It's not possible to manually set the 'gds-token' to an empty string, because GitHub ignores this.

Solution: Set the default value to an empty string (as described in the readme).

Best wishes!

oracle-contributor-agreement[bot] commented 1 year ago

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

fniephaus commented 1 year ago

Hi @johannes-link, Thanks for the PR. Could you please share a link to a build that is failing due to this? We are testing different setups and I haven't seen the error you've described.

It'd be great if you could sign the OCA, so that I can merge your contribution.

fniephaus commented 1 year ago

Is this still needed?

johannes-link commented 1 year ago

Hi @fniephaus, sorry for my late reply. I used the GitHub action in the public GitHub and there it worked without any issues. In my real project I use GitHub Enterprise and self-hosted runners. There I get the 'bad credentials'-message. So I think there is a issue with our configurations and not with the GitHub action. We can close this PR. Thank you!

fniephaus commented 1 year ago

There I get the 'bad credentials'-message.

So do you still get this error in your GitHub Enterprise instance? If setting the default helps, I'm happy to fix this for you.

johannes-link commented 1 year ago

Hi @fniephaus, we have switched to the GraalVM Maven plugin. This works fine, so we don't need the change anymore. If nobody else has the same problem, I think it was an issue with our instance and not a general problem. But thanks for your support!

fniephaus commented 1 year ago

Ok, great. Glad to hear this is working for you! Also, with the new GraalVM for JDK 17/20 releases made available under the GFTC license, the gds-token option is fortunately no longer needed :)