graalvm / setup-graalvm

GitHub Action for setting up GraalVM distributions.
https://www.graalvm.org
Universal Permissive License v1.0
192 stars 27 forks source link

Error since latest release of GraalVM #42

Closed benweet closed 1 year ago

benweet commented 1 year ago

Since the latest release of GraalVM one hour ago (https://github.com/graalvm/graalvm-ce-builds/releases/tag/jdk-20.0.1) we're having this error :

Screenshot 2023-06-13 at 17 04 35

It seems the release name prefix is jdk- whereas it's supposed to be vm- : https://github.com/graalvm/setup-graalvm/blob/babc303d7e5b8f3062a94b90b49c3444cf291633/src/graalvm.ts#LL28C28-L28C46

turing85 commented 1 year ago

This seems to be caused by

https://github.com/graalvm/graalvm-ce-builds/releases/latest

redirecting to

https://github.com/graalvm/graalvm-ce-builds/releases/tag/jdk-20.0.1

fniephaus commented 1 year ago

Thanks for the report, we are still rolling out the new release and are working to resolve these issues asap.

fniephaus commented 1 year ago

I have just deployed a temporary fix to unblock all latest builds while we are still rolling out the new release: https://github.com/graalvm/setup-graalvm/commit/b11d36630f94ed5864e0a680a979b5afde449e9d

benweet commented 1 year ago

Thanks @fniephaus 👍

I can confirm it's working now :

Screenshot 2023-06-13 at 18 37 58
fniephaus commented 1 year ago

Hold on, let's make sure we clean this up and not break anything. Nothing is usually more permanent than a temporary fix, but this one is not allowed to stay very long. :wink:

ArloL commented 1 year ago

I am using fixed versions of the setup-graalvm action like this: uses: graalvm/setup-graalvm@v1.0.11. Just to be clear: the fix requires an update of the action to have functioning builds again, right?

If yes: Is there no other way to restore 1.0.11's functionality - I am half asking out of laziness and the other half out of stability/reproducability reasons. If an update is necessary: would you please release a new tag, so that the update can be performed via dependabot? Again being lazy :)

fniephaus commented 1 year ago

the fix requires an update of the action to have functioning builds again, right?

Yes, that is correct.

Is there no other way to restore 1.0.11's functionality - I am half asking out of laziness and the other half out of stability/reproducability reasons.

We could move the tag but that is also not a viable solution because a) all tags are stable except for the major tag (v1) and b) we'd need to do this for all tags.

If an update is necessary: would you please release a new tag, so that the update can be performed via dependabot? Again being lazy :)

Of course, v1.0.12 is up now. :)

fniephaus commented 1 year ago

Cleaned up now in https://github.com/graalvm/setup-graalvm/commit/6a5fa2da729df36f5a1cdb0c6e777d1da45729ec and https://github.com/graalvm/setup-graalvm/commit/9180004c5f95421dcd72a5681d0b46ee46df4b6e.