graalvm / setup-graalvm

GitHub Action for setting up GraalVM distributions.
https://www.graalvm.org
Universal Permissive License v1.0
192 stars 27 forks source link

Action installs Oracle GraalVM on top of Mandrel #54

Closed nscuro closed 1 year ago

nscuro commented 1 year ago

The action appears to install the Oracle GraalVM distribution on top of Mandrel, when only Mandrel is configured.

Example build output:

Run graalvm/setup-graalvm@v1
  with:
    distribution: mandrel
    version: mandrel-latest
    java-version: 17
    components: native-image
    github-token: ***
    set-java-home: true
    check-for-updates: true
    native-image-musl: false
    native-image-job-reports: false
    native-image-pr-reports: false
  env:
    JAVA_HOME: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.7-7/x64
    JAVA_HOME_17_X64: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.7-7/x64
/usr/bin/tar xz --warning=no-unknown-keyword --overwrite -C /home/runner/work/_temp/3297c16a-6e0c-4d7f-85f3-8aea9897056d -f /home/runner/work/_temp/9a492745-e727-4331-a37f-0a5e6fbdd33e
Adding mandrel-java17-linux 23.0.1.2-Final to tool-cache ...
This build is using the new Oracle GraalVM. To select a specific distribution, use the 'distribution' option (see https://github.com/graalvm/setup-graalvm/tree/main#options).
/usr/bin/tar xz --warning=no-unknown-keyword --overwrite -C /home/runner/work/_temp/a3b4128c-fd4c-4154-ac03-666871ca017c -f /home/runner/work/_temp/f19211d5-e943-476b-960a-ccc00e42e5c2
Adding graalvm-jdk-17_linux-x64_bin 17 to tool-cache ...
Warning: Mandrel does not support GraalVM components: native-image

It correctly detects that Mandrel was requested (Adding mandrel-java17-linux 23.0.1.2-Final to tool-cache ...), but then proceeds to install Oracle GraalVM (This build is using the new Oracle GraalVM).

Later build steps (here with Quarkus) then report:

[INFO] [io.quarkus.deployment.pkg.steps.NativeImageBuildStep] Running Quarkus native-image plugin on native-image 17.0.8 2023-07-18
GraalVM Runtime Environment Oracle GraalVM 17.0.8+9.1 (build 17.0.8+9-LTS-jvmci-23.0-b14)
Substrate VM Oracle GraalVM 17.0.8+9.1 (build 17.0.8+9-LTS, serial gc, compressed references)
fniephaus commented 1 year ago

Hi @nscuro, thanks for the report. Could you share a link to a failing build please?

nscuro commented 1 year ago

Sure, here you go: https://github.com/DependencyTrack/hyades/actions/runs/5724111667/job/15509962852

fniephaus commented 1 year ago

I think I tracked it down, please restart your build and let me know whether this is fixed now.

nscuro commented 1 year ago

Thanks for the light speed fix! 🚀

Will give it a spin and report back.

nscuro commented 1 year ago

That did it, can confirm: https://github.com/DependencyTrack/hyades/actions/runs/5726712395/job/15517701393?pr=713

Thanks again for addressing it so quickly!

fniephaus commented 1 year ago

Great! Thanks for confirming...and happy building!