graalvm / setup-graalvm

GitHub Action for setting up GraalVM distributions.
https://www.graalvm.org
Universal Permissive License v1.0
196 stars 28 forks source link

Added Liberica Native Image Kit as new distribution #87

Closed petermz closed 8 months ago

petermz commented 8 months ago

This PR addresses #76. Liberica is supported in pretty much the same fashion as GraalVM, e.g.

distribution: liberica
java-version: 17.0.10

It appeared logical to me to reuse several functions from utils.ts, so I converted a few constants used there into parameters. Also added tests, notes, and bumped version.

TKaxv-7S commented 8 months ago

Hi, I was Fixed 'version' parameter at this Pull

fniephaus commented 8 months ago

The failure on Windows is unrelated to this PR. I'll take care of it.

TKaxv-7S commented 8 months ago

Hi, I was Fixed 'version' parameter at this Pull

This PULL also fixed the issue of not being able to download the latest version of graalvm.

petermz commented 8 months ago

Addressed rest of the comments

fniephaus commented 8 months ago

This is now live and available via v1.2.0. I rebase the commits and unfortunately GitHub didn't detect that, but this PR is merged now. Again, thanks for the contribution!