Improve make_component.sh

graalvm / simplelanguage

A simple example language built using the Truffle API.

http://openjdk.java.net/projects/graal/

Universal Permissive License v1.0

614 stars 199 forks source link

Improve make_component.sh #72

Open fniephaus opened 5 years ago

fniephaus commented 5 years ago

This PR improves make_component.sh in the following ways:

"Exit immediately if a command exits with a non-zero status." (set -e)
Fix incorrect rm -rf COMPONENT_DIR and add user prompt before deleting directory
Suggest to run mvn package when simplelanguage.jar is not found
Use pushd/popd in favor of cd
Mark variables as readonly
Minor consistency fixes

boris-spas commented 5 years ago

Could you please rebase? I merged a PR that made some changes to the script in question and re-enabled the part of the gate that checks the components.

fniephaus commented 5 years ago

Done! PTAL