search

graalvm / vscode-extensions

Universal Permissive License v1.0
31 stars 8 forks source link

Bug fix for not finding Graalvm instance and typo's #14

Open reinbeumer opened 3 years ago

reinbeumer commented 3 years ago

Just some typo's of missing semicolons, trippel = and non braced if statements

graalvmbot commented 3 years ago

Hello brein, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address reinbeumer -(at)- gmail -(dot)- com. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

reinbeumer commented 3 years ago

I did sign in, I have an email with the link to the signed OCA

MartinBalin commented 3 years ago

Hello, thanks for PR. The fix in https://github.com/graalvm/vscode-extensions/pull/14/commits/41514465ec482d8b2ca9c7291571ce4001de9737 has to be tested on various platforms and with SDKMan as well.

graalvmbot commented 3 years ago

Hello brein, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address reinbeumer -(at)- gmail -(dot)- com. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.