graasp / graasp-account

GNU Affero General Public License v3.0

0 stars 2 forks source link

feat: update and test the edit personal information interface #283

Closed mariembencheikh closed 3 months ago

mariembencheikh commented 3 months ago

257

spaenleh commented 3 months ago

@mariembencheikh It looks like in your last commit you formatted more files than necessary with prettier.

The issue looked like it was only on src/components/main/MainMenu.tsx. But you formatted also the yarn config, changelog and public/.siteconfig.

What command did you use ? yarn prettier:write should not touch these files. Did you use a command in VSCode ?

Can you please revert your last commit, and only format src/components/main/MainMenu.tsx ? Thank you.

spaenleh commented 3 months ago

@mariembencheikh If this PR is based on code from a previous branch with a PR still open please let us know, so we don't review code twice. You can for example say "This PR is based on (number of the other PR), please review it before this one."

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

spaenleh commented 3 months ago

@mariembencheikh Nice thank you for the work ! I will take this PR, rebase it on my changes and merge it !