graasp / graasp-auth

2 stars 2 forks source link

fix: make redirection screen more user friendly #485

Closed spaenleh closed 1 month ago

spaenleh commented 1 month ago

When the user comes from graasp.org the url query param is not set. When the user goes to auth.graasp.org the backend does not provide a url to go to and the redirection screen does not know where to send the user.

To fix this issue:

Current Screen:

Screenshot 2024-10-22 at 08 57 30

New Screen:

Screenshot 2024-10-22 at 10 24 19

close #484

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

spaenleh commented 1 month ago

@pyphilia I tried with the automatic redirection and I did not really like it. I think it is a bit nicer to have a welcome and click the button. This lets users know that they are logged in. Also this prevents any redirection loops that could be hard to debug if the url param is set to something that makes it look over itself.

sentry-io[bot] commented 1 month ago

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎