[Linux] No desktop icon

graasp / graasp-desktop

Cross-platform desktop client for the Graasp ecosystem.

https://desktop.graasp.org

GNU Affero General Public License v3.0

8 stars 8 forks source link

[Linux] No desktop icon #135

Open bootsa opened 5 years ago

bootsa commented 5 years ago

Desktop icon is not included/shown in Desktop Environment. In panel chooser: Or in task switcher:

Linux Mint Cinnamon 19.1 (Tessa)

juancarlosfarah commented 5 years ago

Thanks for the feedback @bootsa! In the Ubuntu environment used to test the app, I do see the icon. May I ask how you installed the app?

bootsa commented 5 years ago

Sorry for the slow response.

I was running it straight from source as I had issues running the Snap image (see #143).

The AppImage build works but is also missing the icons.

It should still produce an icon even when run from source, correct?

There seems to be a few potential reasons for it:

might need to be set in BrowserWindow's Icon option - see (this old but seemingly relevant comment)[https://github.com/electron/electron-packager/issues/128#issuecomment-227752065]
it might be my distro/desktop environment (apparently Linux Mint / Cinnamon uses custom / third party icons rather than the app default - from what I came across here)

I'm seeing the same issue with a clean built Electron app. Will investigate further when I have the chance - though I guess this is a lower priority issue.

Are you seeing the correct icon @nunonun?

bootsa commented 5 years ago

Interestingly when opening the about window as fixed by @pyphilia the icon shows up for that window but not the main window (in both the dock and the tab switcher): It looks like because About Window sets the BrowserWindow's icon option...

bootsa commented 5 years ago

Yep, simple as including icon: ICON_PATH in BrowserWindow options.

The image quality is rather poor when shown in the task switcher:

(I think the VS Code icon beside the Graasp icon is 1024 x 1024)

juancarlosfarah commented 5 years ago

@bootsa, thanks for investigating. Normally running using yarn start does not show the icon. However, running a built image should show the right icon. The low resolution seems weird, as in Ubuntu it looks fine. Let's try and get feedback from @NunonuN. @porduna, you also were able to install the app on Linux. Do you have any feedback you could give us?

porduna commented 5 years ago

Using the AppImage version, same icon issue, as well as in GNOME no option to add icon to favorites, etc.; however I guess that for desktop integration, I should install appimaged or AppImageLauncher according to https://docs.appimage.org/user-guide/run-appimages.html

bootsa commented 5 years ago

The weird thing is that in the About window the icon comes out perfectly and is a lot larger than the task switcher version.

On a HiDpi laptop screen that's automatically double scaled but same happens with no scaling (probably not apparent here):

OS: Linux Mint Cinnamon 19.1 Tessa