search

grab / cocoapods-pod-merge

Cocoapods plugin to merge pods used by your Xcode project, reducing the number of dynamic frameworks your app has to load on startup
MIT License
372 stars 24 forks source link

Subspecs support on the MergeFile #22

Open Vkt0r opened 3 years ago

Vkt0r commented 3 years ago

Hey 👋 ! This PR is focused on add support for Subspecs in the MergeFile.

The issue was the Subspecs were treated as they were by the plugin. If AppAuth/Core was added to the MergeFile the plugin was expecting a folder called AppAuth/Core would exist and this is not how this is handled. Two specific changes were made to support this:

  1. Remove the subspecies from the original list of Pods to verify with folders, for example AppAuth/Core will be AppAuth only.
  2. When the the Podspecs are extracted the Subspecs names are AppAuth_Core so it's necessary to keep control of the original list to replace it and add the corresponding Podspecs.

This PR can be resumed in the following:

Closes #11

Vkt0r commented 3 years ago

@biocross Any change you can take a look into the 3 PRs solving issues in the project ??

Vkt0r commented 3 years ago

@biocross Any chance you can take a look into the 3 PRs solving issues in the project ??

biocross commented 3 years ago

Hello @Vkt0r, really appreciate the PRs! I'll take a look this weekend and sometime next week. Thanks again!

Vkt0r commented 3 years ago

@biocross Great !! Thank you!!! I do have more PRs to fix more issues with the import XX resolutions etc. But let's work with these first.

dwirandyh commented 2 years ago

any update for this PR? @Vkt0r @biocross

ShenYj commented 5 months ago

is it on going?