search

grabs / moodle-tool_userdebug

3 stars 5 forks source link

Add options to choose where the debug toggle sits #12

Open brendanheywood opened 2 months ago

brendanheywood commented 2 months ago

There has been some discussion around where the toggle should sit. Some options:

1) in the top nav bar (where it is now) 2) in the menu under the profile drop down - still on every page and quick to access but less cluttered up front 3) somewhere else more buried? I'm less keen on this as if it isn't handy then it won't be as convenient to use

dmitriim commented 2 months ago

+ 1 for this one.

IMHO you don't want this toggle to be around all the time. How important is to know that it's on/off so you want a toggle be always visible? How often do you need to change adhoc debugging?

dmitriim commented 2 months ago

Ah I think I read it incorrectly. I was confused and thought the toggle enables adhoc task debugging :man_facepalming:

jwalits commented 1 month ago

We just had a request from a client to have the icon not visible on the navbar at all.

Maybe we have a option in the settings, to choose where this option sits. Have two options - visible all the time like it is now or in the usermenu?

brendanheywood commented 1 month ago

The other benefit of moving it to the user menu over render_navbar_output is that render_navbar_output just accepts random html, it would be better if we used a callback or hook which accepted an action_link so that no matter where it was injected if would look correct in the current theme.

This would need to land first in core:

https://tracker.moodle.org/browse/MDL-71823