gracekishino / coding_playlists

Coding Playlists Website
https://coding-playlists.netlify.app
7 stars 12 forks source link

[Content] Add link to contribute #16

Closed gracekishino closed 10 months ago

gracekishino commented 10 months ago

Add the text "Contribute to Coding Playlists →" aligned to the right under the header and link it to https://github.com/gracekishino/coding_playlists (opens in a new tab).

Jainil2004 commented 10 months ago

hi @gracekishino, I am interested in contributing to your project and would love to solve this issue. could you please assign this issue to me? as I am interested in solving this issue. Thanks

gracekishino commented 10 months ago

@Jainil2004 thanks so much! You are assigned :)

Jainil2004 commented 10 months ago

hi @gracekishino, so i was traveling for the past two days, sorry for not reporting to you early about this. I'll start right away with this issue on priority basis, I hope you understand. Also can you please tell me like any is there any specific thing you would like me to address in this issue? or like tell me how should I proceed. Thank you

gracekishino commented 10 months ago

@Jainil2004 no worries and take as long as you need :)

Here are the steps to make the update:

  1. Fork the coding_playlists repository to your GitHub.
  2. Create a new branch on your coding_playlists repository called something like 16-add-contribute-link.
  3. Edit index.html on the new branch to add in the contribute link.
  4. Create a pull request to this repository (grace_kishino/coding_playlists)

Let me know if you need any more pointers for making the update!

Jainil2004 commented 10 months ago

hi @gracekishino, thank you for the steps to make the update. I have another query which is related to styling. do I also have to make modifications in the style.css file? or only the index.html file? thank you

Jainil2004 commented 10 months ago

@gracekishino, I have completed this issue and just wanted to give you a preview of the work before actually submitting a PR. so that you can provide me with your valuable feedback and makes changes if something seems out of place. Based on my understanding, the issue was to add a link that links to the original repository inside the header tag. Now since no context was provided about what type of tag was supposed to be used other than the anchor tag. I compared the tags myself and used the one which I felt perfect. I have attached screenshots related to the issue

code: image

output: image

please have a look and do let me know if any changes are to be made. I'll be very happy to help. Thank you so much for providing me with this opportunity.

Jainil2004 commented 10 months ago

@gracekishino also if you are satisfied with my work. let me know and I'll generate a PR ASAP Thank you

gracekishino commented 10 months ago

@Jainil2004 thanks so much this looks great!

As you suggested I think it's a good idea to move the styles into style.css, something like:

#contribution_link {
   text-align: right;
   color: #fff;
   text-decoration: none;
}

Then can generate the PR :)

Jainil2004 commented 10 months ago

hi @gracekishino thank you for your valuable review. Based of your review, I will move the styling part into the style.css file and will also generate a PR which will provide you with all the changes I've made. Thank you

Jainil2004 commented 10 months ago

@gracekishino I observed one thing in the code snippet you provided that is we are setting the color as #fff but if you look in the code I've written the id traces back to the H4 heading housing the anchor link. So by setting the color nothing actually happens as the text is part of the anchor link and not the heading link. so my question is do we want to change the text color inside the anchor tag to white or not ?

gracekishino commented 10 months ago

@Jainil2004 thanks for catching that! Yes I wanted the text in the anchor to be white, so something similar to this:

#contribution_link {
   text-align: right;
}

#contribution_link a {
   color: #fff;
   text-decoration: none;
}
Jainil2004 commented 10 months ago

@gracekishino thank you so much for clarifying that. I'll work on that portion now and will get back to you soon with the desired changes requested by you.

gracekishino commented 10 months ago

@Jainil2004 Thank you!

By the way we can we can do a code review from a pull request, so it's OK to submit a pull request with the changes even if they haven't been checked by a maintainer first.

Jainil2004 commented 10 months ago

@gracekishino I have made minor changes to the code. please have a look at the changes in the code. Also i will submit a PR so that you can code review from the pull request.

Jainil2004 commented 10 months ago

@gracekishino I have submitted a PR. please have a look and do let me know if any changes are required to be made. I will be very happy to help. Thank you