gracekishino / coding_playlists

Coding Playlists Website
https://coding-playlists.netlify.app
7 stars 12 forks source link

Resolved Issue #4 #40

Closed Jainil2004 closed 8 months ago

Jainil2004 commented 8 months ago

DESCRIPTION OF THE PULL REQUEST

The goal of this PR is to enhance the Layout of the project by adding tabbed nav links

CHANGES MADE

DESCRIPTION OF THE CHANGES MADE

RELATED ISSUES

SCREENSHOTS (IF ANY)

  1. buttons and text for nav image image

  2. user experience hovering over the bold text ("nav bar") highlights the header directing the user image

CHECKLIST

netlify[bot] commented 8 months ago

Deploy Preview for coding-playlists ready!

Name Link
Latest commit 174cb61aa732b5e605cfaa83fafde16b76a5b3d3
Latest deploy log https://app.netlify.com/sites/coding-playlists/deploys/65d4df38bd6a400008df9886
Deploy Preview https://deploy-preview-40--coding-playlists.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Jainil2004 commented 8 months ago

Thanks for this it looks great and much easier to navigate between the content!

I reviewed and suggested some changes. Please can you also add in one more update to the code so that the Spotify button is highlighted on the page load?

i am trying my best to address this but i am facing troubles because whatever I am trying ends up breaking other components.

gracekishino commented 8 months ago

@Jainil2004 thanks for making all the updates! No worries about highlighting the spotify button on load, I will take a look and see if I can figure a way to get it to work. I think your work for this will really improve the site so I'll merge in the changes now.

It's alright this time, but next time you make a pull request please can you create new branch for the pull request (called something like 4-add-tabs) and request to merge that rather than from your main branch? Thanks!