search

gracelang / minigrace

Self-hosting compiler for the Grace programming language
39 stars 22 forks source link

Replaces StandardPrelude with standardGrace #202

Closed petercowal closed 8 years ago

petercowal commented 8 years ago

That's all.

apblack commented 8 years ago

I noticed that the travis-ci tests were failing.

I rebased this on the (then) current master, but the tests still failed. Looking at the diffs, it seems that there are a lot of whitespace errors in the sources.

I'm now unsure if these errors were introduced by my rebase, or by your editor ... I do know that the tests failed before the rebase ... I'm rolling back to your version and seeing what happens there.

apblack commented 8 years ago

@So I've rolled back to your version — the whitespace errors were caused by rebasing. It's because your editor removed trailing whitespace — not a bad thing in itself, but it created a lot of differences that rebase tried to resolve, apparently wrongly.

Now I'm seeing (I think) the same errors that I saw before in the test run on Travis: most of the js tests fail with 

js/tests/harness minigrace js/tests "" 
{ _value: 'no method \'TypeIntersection\' on the "standardGrace" module.' }
undefined

I think that there are actually two errors here: the one being reported, and another in the error reporting machinery itself, since the message that we are seeing is a Javascript error.

petercowal commented 8 years ago

I've determined that the JS errors were at least in part caused by the special case described in grace.in. A fix is in progress.