Closed petercowal closed 8 years ago
Why? While it is rare, we might want to have a writable variable that is not readable.
On Aug 8, 2016, at 4:08 PM, Peter Cowal notifications@github.com wrote:
That's all.
You can view, comment on, or merge this pull request online at:
https://github.com/gracelang/minigrace/pull/211 https://github.com/gracelang/minigrace/pull/211 Commit Summary
Removes "is writable" from lexer File Changes
M lexer.grace https://github.com/gracelang/minigrace/pull/211/files#diff-0 (28) Patch Links:
https://github.com/gracelang/minigrace/pull/211.patch https://github.com/gracelang/minigrace/pull/211.patch https://github.com/gracelang/minigrace/pull/211.diff https://github.com/gracelang/minigrace/pull/211.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gracelang/minigrace/pull/211, or mute the thread https://github.com/notifications/unsubscribe-auth/ABuh-mFzsvqfpWQcrxi1oPOv_xTwJZgwks5qd7bwgaJpZM4JfkL1.
I didn't even think about that interpretation. No worries, this pull request doesn't adjust functionality in any meaningful way (unless someone wants to write a program to mess with the lexer during operation...?); it simply assigns a better scope to some of the lexer's fields.
Due to https://github.com/gracelang/minigrace/issues/186, the current lexer implementation (which uses objects declared within a class to modify fields) needed to have its variables declared as writable. Since the known-good compiler was bumped to fix this issue, it makes sense to restore the original intended variable scope.
Merged!
That's all.