search

grackle-project / grackle

The Grackle chemistry and cooling library for astrophysical simulations and models.
Other
26 stars 50 forks source link

Answer testing needs improvement #134

Closed brittonsmith closed 5 days ago

brittonsmith commented 1 year ago

One of the tests is currently failing due to drift a in dependencies or compilers that I have been unable to track down. This also appears to be system dependent as I have run on a few setups where the tests are still passing. There seems to be enough variance in the answers that comparing to a single set of answer files is not the best way to do things. The only solution I can think of is moving to a setup where answers are generated on the fly by reverting to a gold standard changeset. I am open to other suggestions.

brittonsmith commented 1 month ago

We could close this with PR #215.