search

grackle-project / grackle

The Grackle chemistry and cooling library for astrophysical simulations and models.
Other
26 stars 50 forks source link

Allow unsupported simulation types to work with grackle yt fields. #213

Closed brittonsmith closed 5 months ago

brittonsmith commented 5 months ago

This is in response to a user request on slack. This minor change will allow non-Enzo simulations to use the yt fields feature of Pygrackle. Currently, we only have a map between simulation parameter names and grackle parameter names for Enzo, but users can still provide them by hand, or at least they could if we didn't raise an exception if a parameter map is not found. This removes the exception and simply prints a warning, allowing the user to proceed.

All of this is fairly undocumented outside of the example Python scripts provided, but I intend to improve that moving forward, but ideally not a part of this pull request.

mabruzzo commented 5 months ago

I totally agree! Merging!

brittonsmith commented 5 months ago

Certainly, will do now. Thanks, both.